Fix wrong PHP_INT_MAX/MIN and PHP_DEBUG PHP 8.4 type #11190
Conversation
kkmuffme
force-pushed
the
php-int-min-max-type-wrong
branch
from
37820f0 to
e3bf3d6
Compare
* Fix vimeo#11189 * Fix PHP_DEBUG constant for PHP 8.4 part of vimeo#11107
kkmuffme
force-pushed
the
php-int-min-max-type-wrong
branch
from
e3bf3d6 to
56d96ec
Compare
|
|
||
| case 'PHP_INT_MAX': | ||
| return Type::getInt(false, PHP_INT_MAX); |
There was a problem hiding this comment.
This and PHP_INT_MIN should not be a literal, instead it should be a generic positive/negative integer, because i.e. running psalm on 32-bit and 64-bit systems will return different results.
There was a problem hiding this comment.
running psalm on 32-bit and 64-bit systems will return different results
It's pointless to support 32-bit in this day and age I think? Windows 11 doesn't have support for 32-bit, PhpStorm isn't available in 32-bit.
Could you pinpoint me on how?
The int value is converted to a float in CI when using the "_" syntax (maybe even without it)
I initially used the int value 37820f0 and this caused things to not work
There was a problem hiding this comment.
PHP_INT_MAX is already correct at least on master, PHP_INT_MIN needs Type::getIntRange(null, -1)
=> technically on 32-bit systems the values are different, however 32-bit systems don't have any practical relevance anymore (e.g. PhpStorm IDE is only available as 64-bit since years, therefore it's safe to assume 32-bit PHP can be ignored)